Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP-6188: Nonce Cap #6188

Merged
merged 9 commits into from
Jan 6, 2023
Merged

Add EIP-6188: Nonce Cap #6188

merged 9 commits into from
Jan 6, 2023

Conversation

Pandapip1
Copy link
Member

@Pandapip1 Pandapip1 commented Dec 20, 2022 •
edited
Loading

The first part of the epic SELFDESTRUCT suite

See also: #6189 , #6190

@Pandapip1 Pandapip1 changed the title Add EIP-XXXX: Nonce Cap Add EIP-6188: Nonce Cap Dec 20, 2022
@github-actions github-actions bot added c-new Creates a brand new proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft t-core labels Dec 20, 2022
@github-actions github-actions bot removed the e-number Waiting on EIP Number assignment label Dec 20, 2022
This was referenced Dec 20, 2022
Merged
Merged
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 20, 2022 •
edited
Loading

A critical exception has occurred:
Message: pr 6188 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

xinbenlv
xinbenlv reviewed Dec 20, 2022
View reviewed changes
Copy link
Contributor

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a good idea for this direction of capping nonce.
I wonder if we shall be even more aggressive by choose capping it at sufficient bit e.g. nonce < 2^128-1 so that it will have another 128bits large enough for almost any useage

@Pandapip1
Copy link
Member Author

I wonder if we shall be even more aggressive by choose capping it at sufficient bit e.g. nonce < 2^128-1 so that it will have another 128bits large enough for almost any useage

That might be a good idea. I was thinking of the functionality being identified by the contract code (see #6189 for what I mean), but it might make sense to go big.

SamWilsn
SamWilsn reviewed Dec 21, 2022
View reviewed changes
EIPS/eip-6188.md Show resolved Hide resolved
EIPS/eip-6188.md Outdated Show resolved Hide resolved
SamWilsn
SamWilsn reviewed Dec 21, 2022
View reviewed changes
EIPS/eip-6188.md Outdated Show resolved Hide resolved
SamWilsn
SamWilsn reviewed Dec 25, 2022
View reviewed changes
EIPS/eip-6188.md Outdated Show resolved Hide resolved
EIPS/eip-6188.md Outdated Show resolved Hide resolved
@Pandapip1
GitHub Copilot fail
460198a 
Other people: "Wait, what do you mean 90% of this was written by an AI?"
@Pandapip1
Add note saying why there are no security considerations
d85c82a
@Pandapip1 Pandapip1 requested review from SamWilsn and removed request for xinbenlv December 25, 2022 23:03
@Pandapip1
Copy link
Member Author

@SamWilsn have incorporated your suggestions.

@poojaranjan poojaranjan mentioned this pull request Dec 27, 2022
Closed
12 tasks
@Pandapip1 Pandapip1 added the e-blocking This PR is required to be merged by another open PR label Dec 27, 2022
@eth-bot eth-bot enabled auto-merge (squash) January 6, 2023 01:51
@eth-bot eth-bot merged commit c3a1a5d into ethereum:master Jan 6, 2023
@Pandapip1 Pandapip1 deleted the nonce-cap branch January 6, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinbenlv xinbenlv xinbenlv left review comments

@eth-bot eth-bot eth-bot approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

Assignees
No one assigned
Labels
c-new Creates a brand new proposal e-blocking This PR is required to be merged by another open PR s-draft This EIP is a Draft t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pandapip1 @eth-bot @xinbenlv @SamWilsn